-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Move locks related tests to local api tests and link the failing lock tests with correct issues #7643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
requested review from
grgprarup,
SagarGi,
saw-jan,
PrajwolAmatya and
ScharfViktor
November 1, 2023 09:01
SwikritiT
removed request for
grgprarup,
SagarGi,
saw-jan,
PrajwolAmatya and
ScharfViktor
November 1, 2023 10:35
SwikritiT
force-pushed
the
tests/issue-7625/coreApiWebdavLocks
branch
2 times, most recently
from
November 2, 2023 07:19
a70c94b
to
03f322d
Compare
SwikritiT
changed the title
[tests-only][full-ci]Link the failing lock tests with correct issues that they are failing with
[tests-only][full-ci]Move locks related tests to local api tests and link the failing lock tests with correct issues
Nov 2, 2023
SwikritiT
requested review from
grgprarup,
SagarGi,
saw-jan,
PrajwolAmatya,
ScharfViktor and
amrita-shrestha
November 2, 2023 07:21
SwikritiT
force-pushed
the
tests/issue-7625/coreApiWebdavLocks
branch
from
November 2, 2023 08:30
03f322d
to
1ce3521
Compare
saw-jan
reviewed
Nov 2, 2023
saw-jan
reviewed
Nov 2, 2023
saw-jan
reviewed
Nov 2, 2023
7 tasks
saw-jan
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ScharfViktor
reviewed
Nov 2, 2023
SwikritiT
force-pushed
the
tests/issue-7625/coreApiWebdavLocks
branch
from
November 3, 2023 09:39
f112968
to
708440a
Compare
SwikritiT
force-pushed
the
tests/issue-7625/coreApiWebdavLocks
branch
3 times, most recently
from
November 17, 2023 06:34
e980c1f
to
1e90cdc
Compare
Signed-off-by: Swikriti Tripathi <[email protected]>
Signed-off-by: Swikriti Tripathi <[email protected]>
SwikritiT
force-pushed
the
tests/issue-7625/coreApiWebdavLocks
branch
2 times, most recently
from
November 17, 2023 08:42
ce75801
to
7d4a78e
Compare
Signed-off-by: Swikriti Tripathi <[email protected]>
SwikritiT
force-pushed
the
tests/issue-7625/coreApiWebdavLocks
branch
from
November 17, 2023 08:57
7d4a78e
to
592f9c9
Compare
ScharfViktor
approved these changes
Nov 17, 2023
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
bot
deleted the
tests/issue-7625/coreApiWebdavLocks
branch
November 17, 2023 10:37
ownclouders
pushed a commit
that referenced
this pull request
Nov 17, 2023
…link the failing lock tests with correct issues (#7643) * Link the failing lock tests with correct issues that they are failing with * Move locks relates tests to new suite Signed-off-by: Swikriti Tripathi <[email protected]> * address reviews Signed-off-by: Swikriti Tripathi <[email protected]> * Add new scenario for trying to lock a folder Signed-off-by: Swikriti Tripathi <[email protected]> --------- Signed-off-by: Swikriti Tripathi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move locks related tests to local api tests and link the failing lock tests with correct issues
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: